[SYCL] Make joint_reduce work with sub_group#8786
Merged
bader merged 2 commits intointel:syclfrom Mar 29, 2023
Merged
Conversation
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
Good find! Could you please add a simple test to prove that it now works as intended? It may be enough to have a test that just ensures it compiles (sycl/test) but E2E testing arguably adds better coverage (sycl/test-e2e).
Note: the unqualified name lookup of joint_reduce in the overload of joint_reduce without an init param was not finding the overload of joint_reduce with an init param (because that declaration was located after it), so it searched for joint_reduce via ADL. With sycl::group, ADL can find both overloads of joint_reduce, but sycl::sub_group = sycl::ext::oneapi::sub_group, ADL finds no joint_reduce in sycl::ext::oneapi. Signed-off-by: Cai, Justin <justin.cai@intel.com>
Signed-off-by: Cai, Justin <justin.cai@intel.com>
jzc
force-pushed
the
joint_reduce_sub_group
branch
from
8ef2edc to
d716762
Compare
Contributor
Contributor
Author
bader
pushed a commit
that referenced
this pull request
Mar 29, 2023
Fixes changes made to `sycl_reduce2020.cpp` E2E test in #8786 - the output array passed to `test` in the `std::complex<double>` case was too small. Signed-off-by: Cai, Justin <justin.cai@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the unqualified name lookup of joint_reduce in the overload of joint_reduce without an init param was not finding the overload of joint_reduce with an init param (because that declaration was located after it), so it searched for joint_reduce via ADL. With sycl::group, ADL can find both overloads of joint_reduce, but with sycl::sub_group = sycl::ext::oneapi::sub_group, ADL finds no joint_reduce in sycl::ext::oneapi.
Fixes #8348